Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Back . and isort . #1115

Closed
wants to merge 1 commit into from
Closed

Back . and isort . #1115

wants to merge 1 commit into from

Conversation

Notnaton
Copy link
Collaborator

@Notnaton Notnaton commented Mar 22, 2024

Describe the changes you have made:

When creating a PR I ran black and isort and it made a lot of changes. seperated the back and isort into a seperate PR

Reference any relevant issues (e.g. "Fixes #000"):

Pre-Submission Checklist (optional but appreciated):

  • I have included relevant documentation updates (stored in /docs)
  • I have read docs/CONTRIBUTING.md
  • I have read docs/ROADMAP.md

OS Tests (optional but appreciated):

  • Tested on Windows
  • Tested on MacOS
  • Tested on Linux

@Notnaton
Copy link
Collaborator Author

Notnaton commented Apr 2, 2024

Merging would maybe cause conflicts with other PRs, just use this as a reminder to black . And isort .

@MikeBirdTech
Copy link
Collaborator

Sorry @Notnaton we let this sit idle for far too long and now the conflicts makes this PR too much work. We're doing a big push for merging some PRs, so it might be helpful to do this again if incorrectly formatted code gets in

@Notnaton
Copy link
Collaborator Author

Sorry @Notnaton we let this sit idle for far too long and now the conflicts makes this PR too much work. We're doing a big push for merging some PRs, so it might be helpful to do this again if incorrectly formatted code gets in

No worries, I just let this stay up as a reminder, not as a potential PR 😅

@Notnaton Notnaton deleted the black-isort branch October 10, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants